Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add minimum node 14.18 version constraint #19112

Merged
merged 1 commit into from Feb 17, 2023
Merged

fix: add minimum node 14.18 version constraint #19112

merged 1 commit into from Feb 17, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 17, 2023 •
edited

🔗 Linked issue

resolves #18868

❓ Type of change

  • 🧹 Chore
  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds two levels of constraint on using Nuxt 2 - it now enforces minimum Node 14.18 on install and also when CLI is invoked. We now use dependencies that rely on the node: protocol and they require this minimum version.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 February 17, 2023 09:57
@danielroe danielroe self-assigned this Feb 17, 2023
@codesandbox
Copy link

codesandbox bot commented Feb 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

pi0
pi0 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (updated title. adding ! bumps to major in automation)

@pi0 pi0 changed the title fix!: add minimum node 14.18 version constraint fix: add minimum node 14.18 version constraint Feb 17, 2023
@danielroe danielroe merged commit 2d07ae6 into 2.x Feb 17, 2023
@danielroe danielroe deleted the chore/version-2.x branch February 17, 2023 10:40
@danielroe danielroe mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
2.x bug chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0