Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-renderer): add csp option for csp v1 compatibility #5975

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

williamchong
Copy link

@williamchong williamchong commented Jun 24, 2019

Fixes CSP compatibility mentioned in #5627

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add a csp option unsafeInlineCompatiblity which allows 'unsafe-inline' and hash based rules to appear together.
Not sure if the option name can be shorter.
Resolves: #5627

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☺️

@manniL manniL requested a review from a team June 24, 2019 10:27
@clarkdo clarkdo merged commit cf39c75 into nuxt:dev Jun 26, 2019
@clarkdo
Copy link
Member

clarkdo commented Jun 26, 2019

@williamchong007 A pr for updating doc will be great.

@koehn
Copy link

koehn commented May 31, 2020

This would have been better had you spelled compatability correctly…

@pi0
Copy link
Member

pi0 commented May 31, 2020

@koehn It is already fixed with #6583 can you spot typo in docs?

@koehn
Copy link

koehn commented May 31, 2020

Not sure if this is what you mean; AFAICT it's still in use as of 2.12.2. Am I looking in the wrong place?

https://nuxtjs.org/api/configuration-render/

@pi0
Copy link
Member

pi0 commented May 31, 2020

Patch is available since 2.10.2. You can use unsafeInlineCompatibility

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot define both SHA hash and unsafe-inline in CSP for best compatibility
6 participants