Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inverse wording of error message #5990

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

hecktarzuli
Copy link
Contributor

Original wording didn't seem to make sense.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Error message seemed to be wrong

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Original wording didn't seem to make sense.
@clarkdo clarkdo changed the title Inverse wording of error message chore: inverse wording of error message Jun 26, 2019
@clarkdo clarkdo merged commit 1d4421e into nuxt:next Jun 26, 2019
@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #5990 into next will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5990      +/-   ##
==========================================
- Coverage   95.72%   95.68%   -0.04%     
==========================================
  Files          82       82              
  Lines        2689     2689              
  Branches      690      690              
==========================================
- Hits         2574     2573       -1     
- Misses         97       98       +1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.35% <ø> (ø) ⬆️
#unit 92.67% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 93.49% <ø> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de526f6...fdb5824. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants