Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): emit triggerScroll to support hash navigation #6012

Merged
merged 3 commits into from
Jul 3, 2019

Conversation

pimlie
Copy link

@pimlie pimlie commented Jul 1, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Nuxt's scrollBehaviour relies on the triggerScroll event which is only emitted when a new component is loaded. This means the event will never be emitted when you navigate within an active component using hashes.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #6012 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6012   +/-   ##
=======================================
  Coverage   95.72%   95.72%           
=======================================
  Files          82       82           
  Lines        2689     2689           
  Branches      690      690           
=======================================
  Hits         2574     2574           
  Misses         97       97           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.35% <ø> (ø) ⬆️
#unit 92.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a49902...91003b2. Read the comment docs.

@pi0 pi0 requested review from Atinux and a team July 1, 2019 09:04
@Atinux
Copy link
Member

Atinux commented Jul 2, 2019

Thanks @pimlie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants