Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: babel polyfill can not be disabled #6021

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 2, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #6019

Polyfill has been are handled by @babel/preset-en, so no need to add in runtime plugin

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #6021 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6021   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          82       82           
  Lines        2689     2689           
  Branches      690      690           
=======================================
  Hits         2573     2573           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.35% <ø> (ø) ⬆️
#unit 92.67% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/babel-preset-app/src/index.js 96.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd242a...eac2ef1. Read the comment docs.

@pi0 pi0 merged commit a56817f into nuxt:dev Jul 3, 2019
@pi0 pi0 mentioned this pull request Jul 24, 2019
Atinux pushed a commit that referenced this pull request Jul 30, 2019
pi0 pushed a commit that referenced this pull request Aug 20, 2019
@clarkdo clarkdo deleted the disable-babel-polyfill branch September 7, 2019 21:53
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can i disabled polyfill ?
4 participants