feat(server): allow passing loadingTimeout and other arguments to renderAndGetWindow()

[yutanoma]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #6008

Currently, it is impossible to give the loadingTimeout option to the renderAndGetWindow from outside. This is very inconvenient, since we cannot avoid the following error.

Error {
  message: 'Components loading in renderAndGetWindow was not completed in 2s',
}

If we can give the loadingTimeout option from the globals option in nuxt.config.js, we can solve this problem. In fact this solution is suggested in #6008 (comment).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-io]

Codecov Report

Merging #6178 into dev will increase coverage by 44.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             dev    #6178       +/-   ##
==========================================
+ Coverage   50.8%   95.74%   +44.93%     
==========================================
  Files         80       80               
  Lines       2655     2655               
  Branches     683      683               
==========================================
+ Hits        1349     2542     +1193     
+ Misses      1008       97      -911     
+ Partials     298       16      -282

Flag	Coverage Δ
#e2e	100% <ø> (ø)	⬆️
#fixtures	50.8% <ø> (ø)	⬆️
#unit	92.42% <ø> (?)

Impacted Files	Coverage Δ
packages/server/src/server.js	97.72% <ø> (+34.09%)	⬆️
packages/webpack/src/config/client.js	98.07% <0%> (+3.84%)	⬆️
packages/webpack/src/utils/perf-loader.js	100% <0%> (+5.26%)	⬆️
packages/webpack/src/config/base.js	94.89% <0%> (+6.12%)	⬆️
packages/utils/src/lang.js	100% <0%> (+6.66%)	⬆️
packages/core/src/module.js	98.33% <0%> (+10%)	⬆️
packages/utils/src/context.js	100% <0%> (+11.11%)	⬆️
packages/cli/src/commands/index.js	11.11% <0%> (+11.11%)	⬆️
packages/utils/src/resolve.js	96.07% <0%> (+13.72%)	⬆️
packages/config/src/config/build.js	100% <0%> (+14.28%)	⬆️
... and 45 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4615a...4dae80d. Read the comment docs.

[clarkdo]

Since globals are not used only for renderAndGetWindow, so we'd better not add loadingTimeout in it.

How about adding third parameter ?

  renderAndGetWindow (url, jsdomOpts, {
    loadedCallback = this.globals.loadedCallback,
    loadingTimeout = 200,
    ssr = this.options.render.ssr,
    globals = this.globals
  } = {}) {
    return renderAndGetWindow(url, jsdomOpts, {
      loadedCallback,
      ssr,
      globals,
      loadingTimeout
    })
  }

[yutanoma]

Ah, I totally agree. It is definitely better since it is easy to customize the arguments externally. Thank you!