Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webpack): simplify transpile normalization #6179

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 3, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team August 3, 2019 20:43
@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #6179 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6179      +/-   ##
==========================================
+ Coverage   95.75%   95.78%   +0.02%     
==========================================
  Files          80       80              
  Lines        2665     2655      -10     
  Branches      686      683       -3     
==========================================
- Hits         2552     2543       -9     
+ Misses         97       96       -1     
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.8% <83.33%> (-0.11%) ⬇️
#unit 92.46% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 94.89% <100%> (ø) ⬆️
packages/webpack/src/config/server.js 100% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f1532...89229ae. Read the comment docs.

Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants