feat(vue-app): add $nuxt.refresh() #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galvez
previously approved these changes
Aug 6, 2019
pi0
reviewed
Aug 6, 2019
Atinux
changed the title
Atinux
changed the title
|
@Atinux Could Maybe not merge in |
pi0
previously approved these changes
Aug 7, 2019
Codecov Report
@@ Coverage Diff @@
## dev #6194 +/- ##
==========================================
- Coverage 95.78% 95.74% -0.04%
==========================================
Files 80 80
Lines 2655 2655
Branches 683 683
==========================================
- Hits 2543 2542 -1
- Misses 96 97 +1
Partials 16 16
Continue to review full report at Codecov.
|
|
We could add this functionality later on key @kevinmarrec, at the moment I prefer to keep it simple :) |
|
@Atinux Yes, surely ! |
Merged
pi0
pushed a commit
that referenced
this pull request
Aug 20, 2019
* feat(vue-app): add $nuxt.refreshPageData() * hotifx: lint * chore: use getMatchedComponentsInstance util * fix: rename to refreshPage * fix: rename to refresh * feat: add $nuxt.$context and handle error * feat: set $nuxt.context * hotfix: test
husayt
added a commit
to husayt/typescript
that referenced
this pull request
Aug 29, 2019
husayt
added a commit
to husayt/typescript
that referenced
this pull request
Aug 29, 2019
This also has been added [here](nuxt/nuxt#6194) $nuxt.context
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Allo to refresh the page data (calling matched pages
asyncData&fetch).Will be used for the preview mode, as well as closing #3504
It also add
$nuxt.contextas alias (instead of$nuxt.$options.context)Checklist: