-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(config): rename devModules
to buildModules
#6203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manniL
reviewed
Aug 9, 2019
manniL
reviewed
Aug 9, 2019
Atinux
previously approved these changes
Aug 9, 2019
kevinmarrec
previously requested changes
Aug 9, 2019
Atinux
approved these changes
Aug 9, 2019
pi0
changed the title
feat: rename
refactor(config): rename Aug 9, 2019
devModules
to buildModules
devModules
to buildModules
Great! It's important that we can somehow track the legacy fallbacks we have to remove for Nuxt 3, so adding it in the error message or as a TODO is the best way (to easily |
@manniL Good idea. I believe we can do this for all parts in a separate chore PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
devModules
, initially introduced by #5102 to have a way to only include some modules during dev/build time and removing from production dependencies at runtime. It was named afterdevDependencies
section inpackage.json
as such modules should not be installed for production environment at all. However the original name is proven to be little confusing and making users thinking it is only for development time. NewbuildModules
name tries to make it more clear.However
devModules
was not documented, backward compatibility with deprecation massage is added to supportdevModules
until 3.x.Checklist: