Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): rename devModules to buildModules #6203

Merged
merged 5 commits into from
Aug 9, 2019
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 9, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

devModules, initially introduced by #5102 to have a way to only include some modules during dev/build time and removing from production dependencies at runtime. It was named after devDependencies section in package.json as such modules should not be installed for production environment at all. However the original name is proven to be little confusing and making users thinking it is only for development time. New buildModules name tries to make it more clear.
However devModules was not documented, backward compatibility with deprecation massage is added to support devModules until 3.x.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 added this to In progress in Nuxt v2.9 via automation Aug 9, 2019
@pi0 pi0 requested a review from manniL August 9, 2019 10:27
@Atinux Atinux self-requested a review August 9, 2019 10:29
Atinux
Atinux previously approved these changes Aug 9, 2019
packages/config/src/options.js Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat: rename devModules to buildModules refactor(config): rename devModules to buildModules Aug 9, 2019
@pi0 pi0 merged commit 560cb57 into dev Aug 9, 2019
Nuxt v2.9 automation moved this from In progress to Done Aug 9, 2019
@pi0 pi0 deleted the feat/build-modules branch August 9, 2019 10:32
@manniL
Copy link
Member

manniL commented Aug 9, 2019

Great! It's important that we can somehow track the legacy fallbacks we have to remove for Nuxt 3, so adding it in the error message or as a TODO is the best way (to easily grep them out) IMO ☺️

@pi0
Copy link
Member Author

pi0 commented Aug 9, 2019

@manniL Good idea. I believe we can do this for all parts in a separate chore PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Nuxt v2.9
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants