Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): no need to set layout on App #7606

Merged
merged 1 commit into from Jun 25, 2020
Merged

fix(vue-app): no need to set layout on App #7606

merged 1 commit into from Jun 25, 2020

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Jun 25, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Fix #7567 when error layout uses layout property.

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #7606 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7606   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files          88       88           
  Lines        3748     3748           
  Branches     1019     1019           
=======================================
  Hits         2634     2634           
  Misses        905      905           
  Partials      209      209           
Flag Coverage Δ
#unittests 70.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0cf8f...0b0e117. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine locally on reproduction too 👍

@pi0 pi0 merged commit fe01ec3 into dev Jun 25, 2020
@pi0 pi0 deleted the fix/error-layout branch June 25, 2020 13:23
@pi0 pi0 mentioned this pull request Jun 26, 2020
@jonian jonian mentioned this pull request Jun 30, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong layoutName
4 participants