Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): remove hash from payload path #7614

Merged
merged 2 commits into from Jun 26, 2020
Merged

fix(vue-app): remove hash from payload path #7614

merged 2 commits into from Jun 26, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 26, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Remove hash when generating payload path from route.

Reproduction link: https://5ef4d189c369b90007efb5a9--nuxt-content.netlify.app/writing/#codeblocks (see devtools)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 changed the title Fix/static hash @pi0 fix(vue-app): remove hash from payload path Jun 26, 2020
@pi0 pi0 changed the title @pi0 fix(vue-app): remove hash from payload path fix(vue-app): remove hash from payload path Jun 26, 2020
@pi0 pi0 requested review from Atinux and a team June 26, 2020 13:45
@codecov-commenter
Copy link

Codecov Report

Merging #7614 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7614   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          88       88           
  Lines        3749     3749           
  Branches     1020     1020           
=======================================
  Hits         2635     2635           
  Misses        905      905           
  Partials      209      209           
Flag Coverage Δ
#unittests 70.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87218b...2a34d08. Read the comment docs.

@pi0 pi0 mentioned this pull request Jun 26, 2020
@pi0 pi0 merged commit a523853 into dev Jun 26, 2020
@pi0 pi0 deleted the fix/static-hash branch June 26, 2020 15:10
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants