types: import types for @nuxt/telemetry and @nuxt/components
#7626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #7626 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 88 88
Lines 3749 3749
Branches 1020 1019 -1
=======================================
Hits 2635 2635
- Misses 905 906 +1
+ Partials 209 208 -1
Continue to review full report at Codecov.
|
pi0
previously approved these changes
Jun 28, 2020
pi0
reviewed
Jun 28, 2020
packages/types/config/index.d.ts
Outdated
| @@ -32,6 +34,7 @@ export interface NuxtOptions extends Configuration { | |||
| buildDir: string | |||
| buildModules: NuxtOptionsModule[] | |||
| cli: NuxtOptionsCli | |||
| components: boolean | Array<string | ComponentsDir> | |||
There was a problem hiding this comment.
There is also object format support (which may be used later on to provide more options
There was a problem hiding this comment.
Ideally the options would be completely defined in @nuxt/components and just imported in @nuxt/types. I will propose a PR to do that if that sounds good to you.
There was a problem hiding this comment.
Indeed. Just published types for both 🙈 Updating deps in a sec.
pi0
changed the title
@nuxt/telemetry and @nuxt/components@nuxt/telemetry and @nuxt/components
pi0
changed the title
@nuxt/telemetry and @nuxt/components@nuxt/telemetry and @nuxt/components
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing types for new Nuxt modules
@nuxt/telemetryand@nuxt/components.Types of changes
Description
Added two new properties to
NuxtConfigtype.Checklist: