Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push navigation not working since 2.13 when using modern bundle #7628

Closed
ThibaultVlacich opened this issue Jun 27, 2020 · 5 comments
Closed

Comments

@ThibaultVlacich
Copy link
Contributor

Version

v2.13.2

Reproduction link

https://codesandbox.io/s/angry-rain-fctwb

Steps to reproduce

Since updating to Nuxt 2.13, every time I click a nuxt-link, the whole page is fully refreshed, instead of just updating the content of the page.
If I rollback to 2.12.x, I have no issue.

The issue is only present when I have modern: 'server', in my nuxt.config.js.

I'm also seeing this error in the console when building:

 ERROR  Cannot read property 'filter' of undefined

  at node_modules/@nuxt/webpack/dist/webpack.js:176:12
  at runMicrotasks (<anonymous>)
  at processTicksAndRejections (internal/process/task_queues.js:97:5)

What is expected ?

Clicking a link does not fully refresh the page

What is actually happening?

Clicking a link fully refreshes the page

This bug report is available on Nuxt community (#c10865)
@ghost ghost added the cmty:bug-report label Jun 27, 2020
@jjelev
Copy link

jjelev commented Jun 29, 2020

I believe we have related issue here. Check
https://cmty.app/nuxt/nuxt.js/issues/c10826#comment-5ef328c011200fb6dea89a4b

@jjelev
Copy link

jjelev commented Jun 29, 2020

@Atinux I believe the problem lies here:
packages/webpack/src/plugins/vue/modern.js:getAssets

  getAssets (name) {
    const asset = this.assets[name]
    if (!asset) {
      return
    }
    return new Promise((resolve) => {
      watcher.once(name, () => {
        return asset && resolve(asset)
      })
      return asset && resolve(asset)
    })
  }

Should return promise but if there is no asset returns void.

@barfi
Copy link

barfi commented Jun 30, 2020

I got the same error, Nuxt 2.13.2

@pi0
Copy link
Member

pi0 commented Jun 30, 2020

Hi! This is dup of #7562. Fix (#7635) already merged. Stay tuned for next release ;) (you can also use nuxt-edge which has the fix)

@ThibaultVlacich
Copy link
Contributor Author

Confirmed that this is fixed in 2.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants