Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): modern build should wait for legacy assets #7635

Merged
merged 1 commit into from Jun 29, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jun 29, 2020

…odern build is ahead of legacy

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #7562 #7628

Modern build should wait for legacy build setting assets instead of return undefined asset if modern build is ahead of legacy build.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team June 29, 2020 15:13
@codecov-commenter
Copy link

Codecov Report

Merging #7635 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7635   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          88       88           
  Lines        3749     3749           
  Branches     1020     1019    -1     
=======================================
  Hits         2635     2635           
- Misses        905      906    +1     
+ Partials      209      208    -1     
Flag Coverage Δ
#unittests 70.28% <0.00%> (ø)
Impacted Files Coverage Δ
packages/webpack/src/plugins/vue/modern.js 3.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb340c...fda94b0. Read the comment docs.

@pi0 pi0 changed the title fix(webpack): error: cannot read property filter of undefined when m… fix(webpack): modern build should wait for legacy assets Jun 29, 2020
@pi0 pi0 merged commit 23324b9 into dev Jun 29, 2020
@pi0 pi0 deleted the fix/modern-filter-error branch June 29, 2020 15:44
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run dev script with static target and modern client
4 participants