Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): use compact name for concatenated modules #7639

Merged
merged 10 commits into from Jun 30, 2020
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 30, 2020

Update: Additional patch: 2302ffa

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

With #7463 we use [name] for chunknames for easier debugging of production assets but it introduced two new issues:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from aldarund, clarkdo and a team June 30, 2020 12:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #7639 into dev will decrease coverage by 0.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7639      +/-   ##
==========================================
- Coverage   70.28%   70.27%   -0.02%     
==========================================
  Files          88       88              
  Lines        3749     3751       +2     
  Branches     1019     1019              
==========================================
+ Hits         2635     2636       +1     
- Misses        906      907       +1     
  Partials      208      208              
Flag Coverage Δ
#unittests 70.27% <69.23%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/webpack/src/config/client.js 66.66% <60.00%> (-0.44%) ⬇️
packages/config/src/config/build.js 100.00% <100.00%> (ø)
packages/utils/src/resolve.js 98.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b06ab2...66272d3. Read the comment docs.

@manniL manniL changed the title fix(webpack): use compact name for concatinated modules fix(webpack): use compact name for concatenated modules Jun 30, 2020
@pi0
Copy link
Member Author

pi0 commented Jun 30, 2020

Merging to test on edge

@pi0 pi0 merged commit 1edac29 into dev Jun 30, 2020
@pi0 pi0 deleted the fix/chunk-name branch June 30, 2020 17:47
This was referenced Jun 30, 2020
@JBustin
Copy link

JBustin commented Jul 27, 2020

Hello @pi0 after upgrading to nuxt 2.13, I experiment this bug :

Capture d’écran 2020-07-27 à 11 05 21

Seems to be the same problem.
Is there a manner to temporary fix it with webpack configuration ?

@pi0
Copy link
Member Author

pi0 commented Jul 27, 2020

Hi @JBustin. Sorry for this issue. 2.14 release is planned today meanwhile you can also use nuxt-edge package (same code published nightly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic routing broken with AWS API Gateway
4 participants