Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): handle nuxt static command #7647

Merged
merged 1 commit into from Jul 1, 2020
Merged

fix(cli): handle nuxt static command #7647

merged 1 commit into from Jul 1, 2020

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Jul 1, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Ignore static as a valid directory since we want to introduce nuxt static command from an external module.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@Atinux Atinux changed the title fix: handle nuxt static command fix(cli): handle nuxt static command Jul 1, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #7647 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7647   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files          88       88           
  Lines        3751     3751           
  Branches     1019     1019           
=======================================
  Hits         2636     2636           
  Misses        907      907           
  Partials      208      208           
Flag Coverage Δ
#unittests 70.27% <100.00%> (ø)
Impacted Files Coverage Δ
packages/cli/src/run.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fe682...3b4e65d. Read the comment docs.

@pi0 pi0 merged commit d8dace9 into dev Jul 1, 2020
@pi0 pi0 deleted the fix/static-command branch July 2, 2020 10:33
@pi0 pi0 mentioned this pull request Jul 2, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants