Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples(with-sockets): deprecated callback and use cjs #7650

Merged
merged 3 commits into from Jul 2, 2020

Conversation

ReadB
Copy link

@ReadB ReadB commented Jul 1, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

I've changed the asyncData to use a promise after callback deprecation in #4256

WARN  Callback-based asyncData, fetch or middleware calls are deprecated. Please switch to promises or async/await syntax

Reverted changes made to server.js and nuxt.config.js in #3041
53e98a9#diff-7445ee6677ce80f851873540500d61ea
as they are not modules when running yarn dev (nodemon)

(node:12107) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
SyntaxError: Cannot use import statement outside a module
SyntaxError: Unexpected token 'export'

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #7650 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7650   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files          88       88           
  Lines        3751     3751           
  Branches     1019     1019           
=======================================
  Hits         2636     2636           
  Misses        907      907           
  Partials      208      208           
Flag Coverage Δ
#unittests 70.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8dace9...4fb4923. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks 👍

@pi0 pi0 changed the title examples(with-sockets): Deprecated callback & SyntaxError examples(with-sockets): deprecated callback and use cjs Jul 2, 2020
@pi0 pi0 merged commit 86f69e4 into nuxt:dev Jul 2, 2020
@pi0 pi0 mentioned this pull request Jul 2, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants