fix(vue-app): scrollRestoration hasn't set #8055
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #8055 +/- ##
=======================================
Coverage 68.98% 68.98%
=======================================
Files 91 91
Lines 3847 3847
Branches 1047 1047
=======================================
Hits 2654 2654
Misses 969 969
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -663,3 +663,9 @@ export function stripTrailingSlash (path) { | |||
| export function isSamePath (p1, p2) { | |||
| return stripTrailingSlash(p1) === stripTrailingSlash(p2) | |||
| } | |||
|
|
|||
| export function setScrollRestoration (newVal) { | |||
There was a problem hiding this comment.
Don't think we need this function, any benifis for not setting scrollRestoration as we already have 'scrollRestoration' in window.history checking ?
There was a problem hiding this comment.
'scrollRestoration' in window.history` not check for setter of this property.
Angular do this function, but i think simple try/catch simpler
|
@Kolobok12309 Thanks! |
Try catch block for setting
window.history.scrollRestorationTypes of changes
Description
We have a lot of bug-reports with error
Cannot set property scrollRestoration of [object History] which has only a getter, this not critical setterFor fix it, i add try/catch block, while setting this prop
Checklist: