Skip to content

fix(cli): mode deprecation with explicit spa or universal flag #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 30, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Fix #8133
Fix #8044 (comment)

Assign ssr instead of mode when using --spa or --universal flag in cli

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@clarkdo clarkdo requested a review from pi0 September 30, 2020 12:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #8134 into dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8134      +/-   ##
==========================================
+ Coverage   68.91%   68.93%   +0.01%     
==========================================
  Files          91       91              
  Lines        3851     3853       +2     
  Branches     1048     1049       +1     
==========================================
+ Hits         2654     2656       +2     
  Misses        972      972              
  Partials      225      225              
Flag Coverage Δ
#unittests 68.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cli/src/utils/config.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e93d0...5311255. Read the comment docs.

@atinux atinux self-requested a review October 5, 2020 10:26
@pi0 pi0 merged commit 202f355 into dev Oct 8, 2020
@pi0 pi0 deleted the cli-flag branch October 8, 2020 14:30
@pi0 pi0 mentioned this pull request Oct 13, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mode option is deprecated message when running yarn dev --spa
5 participants