Skip to content

fix(generator): handle when no routes.json defined #8166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2020

Conversation

atinux
Copy link
Member

@atinux atinux commented Oct 8, 2020

Should fix nuxt-community/router-module#83

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Should fix nuxt-community/router-module#83

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #8166 into dev will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8166      +/-   ##
==========================================
- Coverage   68.91%   68.90%   -0.01%     
==========================================
  Files          91       91              
  Lines        3851     3853       +2     
  Branches     1048     1048              
==========================================
+ Hits         2654     2655       +1     
- Misses        972      973       +1     
  Partials      225      225              
Flag Coverage Δ
#unittests 68.90% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/generator/src/generator.js 85.85% <66.66%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfaa196...371b865. Read the comment docs.

atinux and others added 4 commits October 8, 2020 14:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pi0 pi0 merged commit 34f3211 into dev Oct 8, 2020
@pi0 pi0 deleted the fix/generate-custom-router branch October 8, 2020 14:29
@pi0 pi0 mentioned this pull request Oct 13, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate static pages with nuxt-generate
4 participants