-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix(vue-app): handle missing payloads on full static #8314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #8314 +/- ##
==========================================
- Coverage 68.70% 68.58% -0.12%
==========================================
Files 91 91
Lines 3863 3871 +8
Branches 1051 1054 +3
==========================================
+ Hits 2654 2655 +1
- Misses 982 987 +5
- Partials 227 229 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
One more suggestion: We shall preload |
d5edf0c
to
c7dbae1
Compare
It would be good to add the ability to check there is a newer version of code available on the server and (if so) refresh in the background. |
Types of changes
Description
In full static, we generate a
payload.js
for each route, expect for ignored pages.When navigating on client-side to a page not statically generated, it will anyway try to fetch the payload, leading to a 404 error in the console:
This PR will create a
manifest.js
grouping all routes generated, so we can avoid fetching payloads for not generated routes.Left to do:
manifest.js
instead withroutes
key inside (will be useful later on to add more fields)router.base
definedgenerate.manifest
to disable the behaviour when in serverless (payload can be generated on-demand)Fixes #7717
Checklist: