Skip to content

fix(vue-app): warn if promises and functions are in fetch state #8348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2020

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 15, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Resolves #8338

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@codecov-io
Copy link

codecov-io commented Nov 15, 2020

Codecov Report

Merging #8348 (518d7a2) into dev (57aa7cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8348   +/-   ##
=======================================
  Coverage   68.55%   68.55%           
=======================================
  Files          91       91           
  Lines        3876     3876           
  Branches     1056     1056           
=======================================
  Hits         2657     2657           
  Misses        991      991           
  Partials      228      228           
Flag Coverage Δ
unittests 68.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aa7cc...518d7a2. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review November 15, 2020 11:01
@danielroe danielroe changed the title fix(vue-app): exclude promises and functions from fetch state fix(vue-app): warn if promises and functions are in fetch state Nov 15, 2020
@pi0 pi0 merged commit 7278b10 into nuxt:dev Nov 16, 2020
@danielroe danielroe deleted the 8338-fetch-functions branch November 16, 2020 08:49
@pi0 pi0 mentioned this pull request Nov 30, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions declared in data are cleared when fetch is present
3 participants