Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): respect router.trailingSlash when serving static files #8398

Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix(cli): respect router.trailingSlash when serving static files #8398

merged 2 commits into from
Nov 30, 2020
+2 −1

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 25, 2020 •
edited
Loading

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

serve-static defaults to redirect directories to trailingSlash (see docs). This PR respects the user's choice (defaulting not to redirect).

This does change behaviour because it will no longer redirect by default (i.e. if trailingSlash is undefined), but this will almost certainly only be true on the local machine as it's unlikely users will serve their static sites in production with nuxt start

closes #8350

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@danielroe
fix(cli, server): respect router.trailingSlash when serving static …

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 37103C9F8C1817F1
Verified
Learn about vigilant mode
62bc359 
…files

https://github.com/expressjs/serve-static#redirect

closes #8350
@danielroe
fix: revert change to server (as irrelevant)

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 37103C9F8C1817F1
Verified
Learn about vigilant mode
0e5a063
@danielroe danielroe changed the title fix(cli, server): respect router.trailingSlash when serving static files fix(cli): respect router.trailingSlash when serving static files Nov 25, 2020
@danielroe danielroe marked this pull request as ready for review November 25, 2020 23:31
@atinux atinux self-requested a review November 30, 2020 10:15
@pi0 pi0 merged commit 09748d4 into dev Nov 30, 2020
@pi0 pi0 deleted the trailingslash-redirect branch November 30, 2020 14:57
@pi0 pi0 mentioned this pull request Nov 30, 2020
Merged
B-starboy
B-starboy reviewed Dec 1, 2020
View reviewed changes
Copy link

@B-starboy B-starboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a lot of trouble with this router/stash program. Personally I’m glad you guys are working on this. Thanks 🙏

This was referenced Jan 19, 2021
Merged
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B-starboy B-starboy

@TheAlexLichter TheAlexLichter

@atinux atinux

@pi0 pi0

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router trailing slash not behaving as expected.
5 participants
@danielroe @TheAlexLichter @atinux @pi0 @B-starboy