fix: trailingSlash and child routes not working

[pi0]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #8422 also adding dev test for 3 possible values of trailing slash

[vue-router] Named Route 'posts' has a default child route. When navigating to this named route (:to="{name: 'posts'"), the default child route will not be rendered. Remove the name from this route and use the name of the default child route for named links instead.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[rchl]

Maybe you could also add trailingSlash=false version of that testsuite? I guess we don't have any existing testing for it?

[pi0]

@rchl I believe there is a test suit for children without trailing slash:

• https://github.com/nuxt/nuxt.js/tree/dev/test/fixtures/children
• https://github.com/nuxt/nuxt.js/blob/dev/test/dev/children.test.js

[rchl]

trailingSlash=undefined and trailingSlash=false are not handled the same though.

[pi0]

@rchl There is also a unit/snapshot test for routes utility: https://github.com/nuxt/nuxt.js/blob/dev/packages/utils/test/route.test.js

[rchl]

@rchl There is also a unit/snapshot test for routes utility: https://github.com/nuxt/nuxt.js/blob/dev/packages/utils/test/route.test.js

I don't see it testing the trailingSlash: false case which, as I've said, is not entirely identical to it being undefined.

[pi0]

Actually it is :) Anyway agreed that snapshot couldn't cover this issue so added trailing-slash-false dev tests :) (Update: added test for all 3 variants of undefined/false/true)

[danielroe]

I think we should pair this PR with another one for the docs to explain what the behaviour should be as I think there are a variety of different expectations in the related issues...

Happy to pick that up.

[codecov-io]

Codecov Report

Merging #8423 (5596200) into dev (5318172) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #8423      +/-   ##
==========================================
- Coverage   67.93%   67.62%   -0.31%     
==========================================
  Files          91       91              
  Lines        3920     3917       -3     
  Branches     1071     1070       -1     
==========================================
- Hits         2663     2649      -14     
- Misses       1017     1024       +7     
- Partials      240      244       +4     

Flag	Coverage Δ
unittests	67.62% <0.00%> (-0.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/utils/src/route.js	86.25% <0.00%> (-7.01%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5318172...5596200. Read the comment docs.

The base branch was changed.