Skip to content

fix(vue-app): do not preserve state when registering client-side dynamic module #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 13, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

This PR changes the default preserveState: true (on client-side store.registerModule) to instead be true only if there is in fact state to preserve, which allows for registering dynamic store modules on the client-side without having to pass preserveState: false explicitly.

HT to @Timkor for the suggestion.

closes #8445
closes #7046

Checklist:

  • My change requires a change to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl
…mic module

closes #8445
closes #7046
@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #8486 (848ddaa) into dev (dd7f767) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8486   +/-   ##
=======================================
  Coverage   67.96%   67.96%           
=======================================
  Files          91       91           
  Lines        3918     3918           
  Branches     1070     1070           
=======================================
  Hits         2663     2663           
  Misses       1016     1016           
  Partials      239      239           
Flag Coverage Δ
unittests 67.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7f767...848ddaa. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl
@danielroe danielroe marked this pull request as ready for review December 13, 2020 23:24
@pi0 pi0 merged commit 1269773 into dev Dec 14, 2020
@pi0 pi0 deleted the 7046-preserve-state branch December 14, 2020 09:52
@pi0 pi0 mentioned this pull request Jan 4, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants