fix(vue-app, vue-renderer, utils): respect trailingSlash setting for payloads
#8489
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #8489 +/- ##
==========================================
- Coverage 67.95% 67.93% -0.02%
==========================================
Files 91 91
Lines 3916 3920 +4
Branches 1069 1071 +2
==========================================
+ Hits 2661 2663 +2
- Misses 1016 1017 +1
- Partials 239 240 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pi0
previously approved these changes
Dec 14, 2020
danielroe
commented
Dec 14, 2020
Comment on lines
+308
to
+310
| <% if (!nuxtOptions.router.trailingSlash) { %> | ||
| path = withoutTrailingSlash(path) | ||
| <% } %> |
atinux
reviewed
Dec 15, 2020
|
Should be available shortly with |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This respects the route URL so payloads won't be refreshed when
trailingSlash: true. Note this will still refresh payloads if the link doesn't respect thetrailingSlashsettings - there is still a need for a<NuxtLink>that respects the trailingSlash settings.closes #8488
closes #8476
Checklist:
I have added tests to cover my changes(will add tests in fix:trailingSlashand child routes not working #8423)