Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): enable polyfilling of proposal supported by core-js #8545

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Dec 23, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix nuxt/create-nuxt-app#680

We're not polyfilling proposals like Promise.allSettled, this pr is enabling it and the polyfills will be imported they are used in each file.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@clarkdo clarkdo requested review from a team and danielroe and removed request for a team December 23, 2020 13:38
@codecov-io
Copy link

Codecov Report

Merging #8545 (87f595e) into dev (b4663d2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8545      +/-   ##
==========================================
- Coverage   67.57%   67.53%   -0.04%     
==========================================
  Files          91       91              
  Lines        3907     3909       +2     
  Branches     1079     1080       +1     
==========================================
  Hits         2640     2640              
- Misses       1020     1021       +1     
- Partials      247      248       +1     
Flag Coverage Δ
unittests 67.53% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/babel-preset-app/src/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4663d2...87f595e. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Dec 23, 2020

Proposal syntaxes are marked as proposal since they might be removed, changed and there is no widely support (ide, parsers and probably alternative transpilers like esbuild). Is there any reason we enable by default?

@clarkdo
Copy link
Member Author

clarkdo commented Dec 23, 2020

@pi0 This is not babel proposal option, this is for corejs which includes Stage 4 proposals (Finished) like Promise.all and Promise.allSettled, so I think it makes sense to have them imported.

@pi0 pi0 merged commit 0bc9d24 into dev Dec 23, 2020
@pi0 pi0 deleted the core-js-proposal branch December 23, 2020 14:16
@pi0 pi0 mentioned this pull request Jan 4, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel is not working
4 participants