Skip to content

fix(vue-app): scroll to top on route changes only #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

beornf
Copy link

@beornf beornf commented Dec 26, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This change fixes the default scroll behavior by only scrolling to the top of page when the route changes.
Resolves #8553.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@codecov-io
Copy link

Codecov Report

Merging #8557 (2b8414a) into dev (e9650c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8557   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files          91       91           
  Lines        3909     3909           
  Branches     1080     1080           
=======================================
  Hits         2640     2640           
  Misses       1021     1021           
  Partials      248      248           
Flag Coverage Δ
unittests 67.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9650c7...2b8414a. Read the comment docs.

@pi0 pi0 changed the title Scroll to top on route changes only fix(vue-app): scroll to top on route changes only Dec 26, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit ac76229 into nuxt:dev Dec 26, 2020
@pi0 pi0 mentioned this pull request Jan 4, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloading the page causes the scroll position to be reset to the top
4 participants