Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): lint types #8630

Merged
merged 5 commits into from
Jan 13, 2021
Merged

chore(types): lint types #8630

merged 5 commits into from
Jan 13, 2021

Conversation

TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Jan 12, 2021

This PR provides linting support for Nuxt's typescript types.

As my TS skills are not the best, I'd love to have some eyes on the PR 😋

Types of changes

  • Internal setup improvement

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@TheAlexLichter TheAlexLichter requested a review from pi0 January 12, 2021 20:40
@TheAlexLichter TheAlexLichter changed the title types: create a basic linting setup test(types): create a basic linting setup Jan 12, 2021
@pi0 pi0 changed the title test(types): create a basic linting setup chore: lint types Jan 12, 2021
@pi0 pi0 changed the title chore: lint types chore(types): lint types Jan 12, 2021
@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #8630 (0d0a9f4) into dev (1405968) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8630      +/-   ##
==========================================
+ Coverage   66.01%   66.05%   +0.04%     
==========================================
  Files          92       92              
  Lines        4013     4010       -3     
  Branches     1105     1104       -1     
==========================================
  Hits         2649     2649              
+ Misses       1097     1095       -2     
+ Partials      267      266       -1     
Flag Coverage Δ
unittests 66.05% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/webpack/src/utils/style-loader.js 78.57% <0.00%> (+3.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1405968...0d0a9f4. Read the comment docs.

@pi0 pi0 merged commit cff123c into dev Jan 13, 2021
@pi0 pi0 deleted the ts/lint-ts-files branch January 13, 2021 11:22
@pi0 pi0 mentioned this pull request Feb 9, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants