refactor(utils, vue-app): use ufo to parse queries and join urls
#8765
+17
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #8765 +/- ##
==========================================
- Coverage 66.03% 66.02% -0.01%
==========================================
Files 92 92
Lines 4013 4012 -1
Branches 1105 1105
==========================================
- Hits 2650 2649 -1
Misses 1097 1097
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pi0
reviewed
Feb 8, 2021
pi0
reviewed
Feb 8, 2021
packages/vue-app/template/server.js
Outdated
| opts.query = stringify(opts.query) | ||
| opts.path = opts.path + (opts.query ? '?' + opts.query : '') | ||
| opts.path = withQuery(opts.path, opts.query) | ||
| opts.query = stringifyQuery(opts.query || {}) |
There was a problem hiding this comment.
Checking createNext it seems we no longer would need stringifing opts.query (not used until res.end)
There was a problem hiding this comment.
That is very satisfying
danielroe
commented
Feb 8, 2021
packages/vue-app/template/server.js
Outdated
| opts.query = stringify(opts.query) | ||
| opts.path = opts.path + (opts.query ? '?' + opts.query : '') | ||
| opts.path = withQuery(opts.path, opts.query) | ||
| opts.query = stringifyQuery(opts.query || {}) |
There was a problem hiding this comment.
That is very satisfying
danielroe
commented
Feb 9, 2021
pi0
approved these changes
Feb 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
As we're already importing and using
ufo, we can eliminate some of our homegrown URL tools. This PR (so far):urlJoin()functions (duplicates) with theufoequivalentclientUseUrlfeature flag from feat(vue-app): support configurable features #6287)Checklist: