Skip to content

fix: ignore trailing slash in static payloads manifest (#8794) #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 9, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 8, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Checklist:

  • All new and existing tests are passing.

Sorry, something went wrong.

@danielroe danielroe marked this pull request as ready for review February 8, 2021 14:47

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-io
Copy link

Codecov Report

Merging #8794 (e685b04) into dev (da318a5) will increase coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8794      +/-   ##
==========================================
+ Coverage   66.03%   66.06%   +0.03%     
==========================================
  Files          92       92              
  Lines        4013     4011       -2     
  Branches     1105     1100       -5     
==========================================
  Hits         2650     2650              
- Misses       1097     1099       +2     
+ Partials      266      262       -4     
Flag Coverage Δ
unittests 66.06% <28.57%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 0.00% <0.00%> (ø)
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)
packages/generator/src/generator.js 81.30% <25.00%> (ø)
packages/utils/src/route.js 86.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da318a5...e685b04. Read the comment docs.

@pi0 pi0 changed the title fix(generator, vue-app, vue-renderer): ignore trailing slash in manifest/payloads fix: ignore trailing slash in static payloads manifest (#8794) Feb 9, 2021
@pi0 pi0 merged commit c8a4b91 into dev Feb 9, 2021
@pi0 pi0 deleted the ignore-trailingslash-manifest branch February 9, 2021 15:58
@pi0 pi0 mentioned this pull request Feb 9, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants