Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): add leading slash for payload hydration #8802

Merged
merged 8 commits into from
Feb 10, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 9, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Fixes regression reported https://www.github.com/nuxt/nuxt.js/issues/8107#issuecomment-776227825 and https://www.github.com/nuxt/nuxt.js/issues/8107#issuecomment-776222703.

Checklist:

  • I have added tests to cover my changes
  • All new and existing tests are passing.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
@danielroe danielroe marked this pull request as draft February 9, 2021 21:44

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
@danielroe danielroe marked this pull request as ready for review February 9, 2021 22:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
pi0 and others added 3 commits February 10, 2021 12:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #8802 (5d1a5fd) into dev (c221f60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8802   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files          93       93           
  Lines        4026     4026           
  Branches     1102     1102           
=======================================
  Hits         2666     2666           
  Misses       1099     1099           
  Partials      261      261           
Flag Coverage Δ
unittests 66.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c221f60...add6fc8. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pi0 pi0 merged commit 9d33456 into dev Feb 10, 2021
@pi0 pi0 deleted the 8107-hotfix-payload-hydration branch February 10, 2021 12:18
@pi0 pi0 mentioned this pull request Feb 10, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants