fix(server): avoid caching .js assets in development to fix HMR for safari
#9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes reload loop on safari (closes #3828)
clarkdo
previously approved these changes
Mar 23, 2021
clarkdo
reviewed
Mar 23, 2021
pi0
changed the title
.js files in dev mode.js assets in development to fix HMR for safari
pi0
approved these changes
Mar 23, 2021
enwin
pushed a commit
to enwin/nuxt.js
that referenced
this pull request
Mar 25, 2021
enwin
added a commit
to enwin/nuxt.js
that referenced
this pull request
Mar 25, 2021
chore(deps): update dependency @nuxt/components to ^2.1.4 (nuxt#9037) chore(deps): update all non-major dependencies (nuxt#9032) fix(server): avoid caching `.js` assets in development to fix HMR for safari (nuxt#9034) fix(vue-app): re-call `$fetch` if data is missing in payload (nuxt#9026) chore(deps): update all non-major dependencies (nuxt#9029) chore(deps): update dependency node-html-parser to v3 (nuxt#8886) fix(config): compile type compatibility in css-loader v4 (nuxt#9014) chore(deps): lock file maintenance (nuxt#9023) fix(vue-app): handle redirect functions in routes (nuxt#9024) chore(deps): update dependency globby to ^11.0.3 (nuxt#9025) fix(vue-app): use `app.context.route` to match components in server chore(deps): update all non-major dependencies (nuxt#9019)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR turns off caching for webpack-processed JS files in dev mode.
Fixes reload loop on safari (closes #3828).
Previously, `runtime.js` was being cached in-memory by Safari and triggering infinite HMR updates in the following situation: * server started * change made to file (triggering HMR) * server restarted * safari hard reload -> starts infinite loop (because `runtime.js` from first server is loaded from memory)
Note: if you have previously experienced an infinite reload loop, you will need to clear your Safari cache once using
Develop...Empty Cachesand then reload.Checklist: