Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): css-loader v4 type definition #9053

Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix(types): css-loader v4 type definition #9053

merged 1 commit into from
Mar 26, 2021

Conversation

zzzmisa
Copy link

@zzzmisa zzzmisa commented Mar 26, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

I fixed the type definition for CssLoaderOptions to suit css-loader v4.

Also see:
https://github.com/webpack-contrib/css-loader/tree/v4.3.0#options

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

pi0
pi0 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 9065f63 into nuxt:dev Mar 26, 2021
@pi0 pi0 mentioned this pull request Mar 31, 2021
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzzmisa @pi0 @danielroe