Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): add stub entrypoint to allow node resolution of @nuxt/types #9059

Merged
merged 1 commit into from
Mar 28, 2021
Merged

chore(types): add stub entrypoint to allow node resolution of @nuxt/types #9059

merged 1 commit into from
Mar 28, 2021

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

This does add new behaviour (now require.resolve('@nuxt/types') will output a path) but it's not breaking.

see microsoft/TypeScript#18008 (comment)

closes #9030

Checklist:

  • All new and existing tests are passing.

@danielroe danielroe requested a review from pi0 March 27, 2021 14:19
@pi0 pi0 merged commit 248a5c8 into dev Mar 28, 2021
@pi0 pi0 deleted the fix/9030-nuxt-types-module branch March 28, 2021 18:19
@pi0 pi0 mentioned this pull request Mar 31, 2021
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@nuxt/types should be a valid JS package (w/ an index.js) so that TS emitDecoratorMetadata works
2 participants
@danielroe @pi0