Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move internal app runtime config to _app namespace #9075

Merged
merged 1 commit into from
Mar 30, 2021
Merged

refactor: move internal app runtime config to _app namespace #9075

merged 1 commit into from
Mar 30, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 30, 2021 •
edited

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

move internal runtime config to _app from app - and add notification that this is reserved via TS types/IDE autocomplete

History: #8759, #9039

closes #9074

Checklist:

  • All new and existing tests are passing.

@danielroe danielroe requested a review from pi0 March 30, 2021 14:53
@pi0 pi0 merged commit ca020cf into dev Mar 30, 2021
@pi0 pi0 deleted the refactor/app-to-_app branch March 30, 2021 16:38
This was referenced Mar 31, 2021
Closed
Merged
@danielroe danielroe mentioned this pull request Dec 1, 2021
Closed
7 tasks
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specific names in publicRuntimeConfig
2 participants
@danielroe @pi0