Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: inline @types/terser-webpack-plugin #9078

Merged
merged 1 commit into from
Mar 31, 2021
Merged

types: inline @types/terser-webpack-plugin #9078

merged 1 commit into from
Mar 31, 2021

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Mar 30, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Due to latset @types/terser-webpack-plugin change, webpack@5 will be added to our depednecy tree and types will be broekn as well, see build log of #9067, this pr is moving @types/terser-webpack-plugin into nuxt codebase as a quick fix

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from pi0 and danielroe March 30, 2021 22:11
@pi0 pi0 changed the title fix(types): add build-in terser types types: inline terser-webpack-plugins types Mar 31, 2021
@pi0 pi0 changed the title types: inline terser-webpack-plugins types types: inline terser-webpack-plugin types Mar 31, 2021
@pi0 pi0 changed the title types: inline terser-webpack-plugin types types: inline @types/terser-webpack-plugin Mar 31, 2021
@pi0 pi0 merged commit 1be68ca into dev Mar 31, 2021
@pi0 pi0 deleted the fix/terser-types branch March 31, 2021 15:56
@pi0 pi0 mentioned this pull request Mar 31, 2021
Closed
@rchl
Copy link

rchl commented Apr 1, 2021

This was fixed upstream

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clarkdo @rchl @danielroe @pi0