fix(types): use options from sass-loader rather than sass
#9086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pins dependency in case of breaking change (-> webpack 5) in future closes #9085
clarkdo
approved these changes
Mar 31, 2021
clarkdo
reviewed
Mar 31, 2021
| @@ -22,7 +22,7 @@ | |||
| "@types/node": "^12.20.7", | |||
| "@types/optimize-css-assets-webpack-plugin": "^5.0.3", | |||
| "@types/pug": "^2.0.4", | |||
| "@types/sass": "^1.16.0", | |||
| "@types/sass-loader": "8.0.1", | |||
There was a problem hiding this comment.
We can also put the package into renovate ingoreDeps for not getting auto upgradation pr
There was a problem hiding this comment.
Currently @types/webpack@^4 is dependency and as long as that remains we should be fine with upgrades but we'll need to examine lockfile before approving them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
closes #9085
Checklist: