fix(vue-app): null check for $root access

[PayelKarmakar06]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #9149

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[clarkdo]

Can you please provide more info about your issue and how can $root be undefined ?

[PayelKarmakar06]

For me while loading the application, packages/vue-app/template/index.js file is being visited 4 times, but in the last instance $root is becoming undefined. I am not sure why.
The control is not going beyond - const globalNuxt = this.$root.$options.<%= globals.nuxt %> , as this.$root is not available.
And it is happening from nuxt@2.14.7

[(https://github.com//issues/9149)]
@clarkdo

[clarkdo]

The change itself looks fine, but I think it might hide the root cause which we'd better investigate.

/cc @pi0 @danielroe

[PayelKarmakar06]

It's a little urgent, we have to upgrade from nuxt@2.14.6 very soon to handle some of the vulnerabilities. Would it be possible for you to approve this PR and keep the issue ticket open to keep the root cause analysis under radar? @clarkdo

[clarkdo]

@pi0 @danielroe Any idea about this ?

[danielroe]

I agree with @clarkdo.

The issue (see also #8359) is likely a consequence of #8170.

@PayelKarmakar06 Could you provide a reproduction of your issue using https://template.nuxtjs.org?

[PayelKarmakar06]

@danielroe as I mentioned earlier, I am not sure why this is happening. I tried to provide a repro already, but was not successful in my attempt.

[PayelKarmakar06]

Hi @danielroe / @clarkdo / @pi0,
Is there any possible way to proceed without providing the repro? It's a minimal change, and should not cause any side effect. I really need this change to be able to upgrade to the latest version of Nuxt.

[PayelKarmakar06]

@danielroe , is there any way to fix it without providing the repro?

[pi0]

Having a reprodution would be much better but since it is an effect of recent refactor (#8170) let's have it. And sorry for delay @PayelKarmakar06. You can try it by using nuxt-edge package.

[PayelKarmakar06]

@pi0 thanks a lot!