New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): use javascript/auto
for js rule
#9180
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #9180 +/- ##
=======================================
Coverage 65.10% 65.10%
=======================================
Files 94 94
Lines 4098 4098
Branches 1121 1121
=======================================
Hits 2668 2668
Misses 1152 1152
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
For supporting |
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
wp5 dependency. closes #9146
this helps avoiding regressions like #9268. in 2.16 we probably start bundling type dependencies
* chore(deps): update all non-major dependencies * revert @types/webpack-dev-middleware update * renew yarn.lock (closes #9260) * chore: ignore cve 1693 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Pooya Parsa <pyapar@gmail.com>
.mjs
workaround to default webpack configjavascript/auto
for js rule
(Note, this is not sufficient to solve this issue when using with PNP.) |
Will there be a release including this change soon? :) Just wondering, I've been waiting for that since early June 🤩 |
Soon @dargmuesli with 2.16 (since is a risky change). In the meantime, you can try using |
Types of changes
Description
Webpack 4 +
.mjs
dependencies currently causes an issue where that package's sub-dependencies are not imported in the correct context and the following error is generated (for example):This PR turns off webpack 4's .mjs handling to avoid broken dependencies. I expect this will be a temporary fix whilst the ecosystem moves to native ESM. Note that there is no such issue in webpack 5.
Checklist: