Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): unregister error event listener #9245

Merged
merged 4 commits into from May 22, 2021
Merged

fix(server): unregister error event listener #9245

merged 4 commits into from May 22, 2021

Conversation

matthieusieben
Copy link

@matthieusieben matthieusieben commented May 6, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@Atinux Atinux requested a review from danielroe May 7, 2021 08:25
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the CI error?

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2021

Codecov Report

Merging #9245 (f4a39c6) into dev (c56d484) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9245      +/-   ##
==========================================
+ Coverage   65.13%   65.16%   +0.03%     
==========================================
  Files          94       94              
  Lines        4101     4105       +4     
  Branches     1124     1124              
==========================================
+ Hits         2671     2675       +4     
  Misses       1152     1152              
  Partials      278      278              
Flag Coverage Δ
unittests 65.16% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/server/src/listener.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56d484...f4a39c6. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix(server): remove un-necessary listener fix(server): unregister error event listener May 22, 2021
@pi0 pi0 merged commit e687842 into nuxt:dev May 22, 2021
@matthieusieben matthieusieben deleted the patch-2 branch May 25, 2021 10:41
@pi0 pi0 mentioned this pull request Aug 11, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants