Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support nuxtrc in dist directory #9280

Merged
merged 8 commits into from May 17, 2021
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 11, 2021

Types of changes

  • New feature (a non-breaking change which adds functionality)

Description

One major weakness of buildModules is that they can't manipulate runtime Nuxt configuration (for example, by injecting a runtime module into the Nuxt config), leaving the invidious choice of having to be installed as a module, asking a user to manually add runtime configuration or other non-optimal choice.

This PR allows manipulation of nuxt.config by placing a nuxtrc file within the .nuxt/dist directory.

Checklist:

  • All new and existing tests are passing.

* allows buildModules to inject runtime modules
@danielroe danielroe requested a review from pi0 May 11, 2021 10:03
packages/config/src/load.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #9280 (a897837) into dev (a53fd32) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9280      +/-   ##
==========================================
+ Coverage   65.10%   65.13%   +0.02%     
==========================================
  Files          94       94              
  Lines        4098     4101       +3     
  Branches     1121     1124       +3     
==========================================
+ Hits         2668     2671       +3     
  Misses       1152     1152              
  Partials      278      278              
Flag Coverage Δ
unittests 65.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/config/src/load.js 75.55% <100.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53fd32...a897837. Read the comment docs.

packages/config/src/load.js Outdated Show resolved Hide resolved
pi0
pi0 previously approved these changes May 11, 2021
packages/config/src/load.js Outdated Show resolved Hide resolved
@danielroe danielroe changed the title feat(config): support .nuxtrc in dist directory feat(config): support nuxtrc in dist directory May 12, 2021
@pi0 pi0 merged commit 186df33 into dev May 17, 2021
@pi0 pi0 deleted the feat/build-dir-nuxtrc branch May 17, 2021 18:53
danielroe added a commit that referenced this pull request May 21, 2021
@pi0 pi0 mentioned this pull request Aug 11, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants