fix(babel-preset-app): respect explicit options.targets for modern preset #9337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Fix #9315
We used to limit targets of modern preset can only be
{esModules: true}
for not breaking matching between browsers which support<script type="module">
and corresponding modern syntax, but it makes sense that let users specify a more modern targets manually if they know exactly what is the target browsers.@pi0 Do you think we need to add a cli info message here about overrding default modern preset targets may break browsers which support
<script type="module">
but not implement more modern ecma syntax yet ?Description
Checklist: