Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): don't normalise route path if it's valid #9460

Merged
merged 1 commit into from Jun 28, 2021

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

After #9431 we were using the normalised path (which might, for example, lack a trailing slash if trailingSlash: true weren't set). This PR reverts that behaviour whilst keeping the fix, at the expense of a double implicit call to router.resolve.

Closes #9442

Checklist:

  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #9460 (e602bea) into dev (35c6ac4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9460   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          94       94           
  Lines        4107     4107           
  Branches     1125     1125           
=======================================
  Hits         2676     2676           
  Misses       1153     1153           
  Partials      278      278           
Flag Coverage Δ
unittests 65.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c6ac4...e602bea. Read the comment docs.

@SnorreAas
Copy link

Any news on when this will be merged?

@pi0 pi0 merged commit eb6bd9f into dev Jun 28, 2021
@pi0 pi0 deleted the fix/trailingslash-navigation branch June 28, 2021 14:29
@rahulkumarsingh73690
Copy link

Please release fix

@kc980602
Copy link

kc980602 commented Jul 27, 2021

Hi, is this going to be released?

@farnabaz
Copy link
Member

farnabaz commented Jul 27, 2021

I believe, It will release in 2.16 but there is no eta for this release.
Meanwhile you can nuxe-edge instead of nuxt. nuxt-edge does include this fix

@kc980602
Copy link

kc980602 commented Jul 27, 2021

@farnabaz

I believe, It will release in 2.16 but there is no eta for this release.
Meanwhile you can nuxe-edge instead of nuxt. nuxt-edge does include this fix

Thanks for the tips 😬

@xjimdim
Copy link

xjimdim commented Aug 11, 2021

Please release 🙏

@pi0 pi0 mentioned this pull request Aug 11, 2021
pi0 pushed a commit that referenced this pull request Aug 11, 2021
@pi0 pi0 mentioned this pull request Aug 11, 2021
@pi0
Copy link
Member

pi0 commented Aug 11, 2021

Released in v2.15.8

@timon0305
Copy link

Screenshot 2023-01-12 at 19 10 27

My node version is 18.12.1 and yarn version is 1.22.19. I tried to install node packages and run project but I got some types of errors like that.
When I change node version, I can see another issue.

@timon0305
Copy link

Screenshot 2023-01-12 at 19 12 20

This is node version 14.15.0 issue.

@timon0305
Copy link

Screenshot 2023-01-12 at 19 12 20

This is node version 14.15.0 issue.

image
it says there is no issue. but project is not running

@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing trailing slash
10 participants