Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): decode route path for payload.js #9494

Merged
merged 2 commits into from Jun 28, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 28, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Previously the payload.js for a non-ascii route contained something like:

__NUXT_JSONP__("/anv%C3%A4ndarhandledning", {data:[{slug:"användarhandledning"}],fetch:{},mutations:void 0});

With this fix we decode the routePath for the payload so we get instead:

__NUXT_JSONP__("/användarhandledning", {data:[{slug:"användarhandledning"}],fetch:{},mutations:void 0});

This way we find the payload correctly (decoded payloads match):

resolves #9011, resolves #9297, resolves #9425

Checklist:

  • All new and existing tests are passing.

@danielroe danielroe requested a review from pi0 June 28, 2021 14:13
@pi0
Copy link
Member

pi0 commented Jun 28, 2021

Thanks!

@pi0 pi0 merged commit 82e4c2d into dev Jun 28, 2021
@pi0
Copy link
Member

pi0 commented Jun 28, 2021

Merged with [release]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants