Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Router config trailingSlash causes error with dynamic nuxt-child routes #9505

Merged
merged 3 commits into from Jul 1, 2021

Conversation

ms-fadaei
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

fix #9472
This bug existed because trailingSlash = true not been considered in a specific condition and exists regex missed it!

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #9505 (267373f) into dev (eb6bd9f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9505      +/-   ##
==========================================
- Coverage   65.15%   65.12%   -0.04%     
==========================================
  Files          94       94              
  Lines        4107     4109       +2     
  Branches     1125     1126       +1     
==========================================
  Hits         2676     2676              
- Misses       1153     1154       +1     
- Partials      278      279       +1     
Flag Coverage Δ
unittests 65.12% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/route.js 85.18% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6bd9f...267373f. Read the comment docs.

packages/utils/src/route.js Outdated Show resolved Hide resolved
@ms-fadaei ms-fadaei requested a review from pi0 July 1, 2021 12:51
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! <3

@pi0 pi0 merged commit 20f481f into nuxt:dev Jul 1, 2021
@pi0 pi0 mentioned this pull request Aug 11, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router config trailingSlash causes error with dynamic nuxt-child routes
5 participants