Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): re-register components construtor in HMR #9539

Merged
merged 2 commits into from Jul 12, 2021
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 11, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Fix #8501
closes #9077

We can see component instance and Component are not matching after hot reload, this pr is re-assigning correct constructor to component instance.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from danielroe and pi0 July 11, 2021 13:51
OsvaldoRino
OsvaldoRino previously approved these changes Jul 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #9539 (e7b88fa) into dev (356de80) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9539   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          94       94           
  Lines        4107     4107           
  Branches     1126     1126           
=======================================
  Hits         2676     2676           
  Misses       1152     1152           
  Partials      279      279           
Flag Coverage Δ
unittests 65.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356de80...e7b88fa. Read the comment docs.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pi0 pi0 merged commit a3b2fd8 into dev Jul 12, 2021
@pi0 pi0 deleted the fix/hmr-component branch July 12, 2021 10:21
@pi0 pi0 mentioned this pull request Aug 11, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncData isn't merged when triggered by watchQuery after HMR in Dev
5 participants