Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-app): pass store to createRouter #9629

Merged
merged 6 commits into from Aug 11, 2021

Conversation

loick
Copy link

@loick loick commented Aug 4, 2021

Resolves #9594

If this PR is validated, I will also create PR on the @nuxt/router module in order to support this parameter as well:
https://github.com/nuxt-community/router-module/blob/18bb2d39b55a9da8abec0a10a9f4552291dc0b39/templates/plugin.js#L10-L11

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@pi0 pi0 changed the title feat(createRouter): Add the store as parameter feat(vue-app): pass store to createRouter Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #9629 (857e9c0) into dev (20e7b99) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9629   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          94       94           
  Lines        4107     4107           
  Branches     1126     1126           
=======================================
  Hits         2676     2676           
  Misses       1152     1152           
  Partials      279      279           
Flag Coverage Δ
unittests 65.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e7b99...857e9c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get the store instance in the Vue router createRouter function
5 participants