Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): loose option for babel private-property-in-object #9631

Merged
merged 1 commit into from Aug 9, 2021

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 5, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Issue #9224 (comment)

Similar fix to #9232.

@babel/plugin-proposal-private-methods has been added to @babel/preset-env now, but the syntax is not supported by webpack 4, so this pr is excluding it from preset-env and setting loose option as a seprate plugin.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from a team, Atinux, pi0 and danielroe and removed request for a team August 5, 2021 09:10
@henrycunh
Copy link

thanks for this!

Copy link

@vinayakkulkarni vinayakkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yosiawan
Copy link

yosiawan commented Aug 7, 2021

nice!

@frederikhors
Copy link

Please! The console gets spammed every time on npm run dev!

Copy link
Member

Atinux commented Aug 10, 2021

@mrleblanc101 can you try nuxt-edge?

@clarkdo
Copy link
Member Author

clarkdo commented Aug 10, 2021

@mrleblanc101 It is closed by issue creator, can you comment in that issue ?

@mrleblanc101
Copy link

Wait this is a merge request. I meant to comment on the issue related to that merge request, my bad.

@Intevel
Copy link
Contributor

Intevel commented Aug 10, 2021

I still have the problem unfortunately, just created a new Nuxt project.

Copy link
Member

Atinux commented Aug 10, 2021

Can you try using nuxt-edge @Intevel ?

@monsieurnebo
Copy link

monsieurnebo commented Aug 11, 2021

Hi @Atinux ,

nuxt-edge is fixing this issue as expected.

When is the next nuxt release (including this fix) planned?

Copy link
Member

Atinux commented Aug 11, 2021

We are working with @pi0 to release it ASAP, some prs are pending at the moment.

@pi0 pi0 mentioned this pull request Aug 11, 2021
pi0 pushed a commit that referenced this pull request Aug 11, 2021
@pi0 pi0 mentioned this pull request Aug 11, 2021
@pi0
Copy link
Member

pi0 commented Aug 11, 2021

Fix released in v2.15.8

@kingyue737
Copy link

I still meet this warning in 2.15.8

@pi0
Copy link
Member

pi0 commented Aug 12, 2021

@kingyue737 Can you please ensure lock file is recreated and you are not using any other workaround inside nuxt.config for babel? If still have issue, a way to reproduction would be nice.

@vinayakkulkarni
Copy link

I still meet this warning in 2.15.8

add this to your sh

alias nbomb='rm -rf node_modules/ package-lock.json && npm i --no-audit'

then do nbomb in your local repo :P

voila!

@kingyue737
Copy link

I still meet this warning in 2.15.8

add this to your sh

alias nbomb='rm -rf node_modules/ package-lock.json && npm i --no-audit'

then do nbomb in your local repo :P

voila!

It works! Thank you

@mrleblanc101
Copy link

Why would you do such a thing, you just need to do npm upgrade or yarn upgrade

@kingyue737
Copy link

Why would you do such a thing, you just need to do npm upgrade or yarn upgrade

I don't know. I npm upgrade and audit fix my dependencies, but the warning still exists. After removing all the packages and reinstalling without auditing, the warning disappears.

@monsieurnebo
Copy link

Thanks for the great work @pi0 👏

@Suv4o
Copy link
Contributor

Suv4o commented Aug 16, 2021

Great @pi0 . Thank you for fixing it✌️

@n4an
Copy link

n4an commented Sep 24, 2021

not work

@n4an
Copy link

n4an commented Sep 24, 2021

Fix released in v2.15.8

is not fixed

@mrleblanc101
Copy link

@Mitch-i it is fixed, read the whole thread of how to update you peerDependancy.

@n4an
Copy link

n4an commented Sep 24, 2021

@Mitch-i it is fixed, read the whole thread of how to update you peerDependancy.

is not fixed, it appear and the problem is not in peerDependancy. i use latest version and a fresh test project

Error: Decorating class property failed. Please ensure that proposal-class-properties is enabled and runs after the decorators transform.

@mrleblanc101
Copy link

@Mitch-i Clearly this is not the same error. You should probably open a new issue with a repro or a step by step guide on how you got this error

@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
@IrtezaAsadRizvi
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet