Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): ensure custom build indicator preserves some whitespace #9705

Merged
merged 1 commit into from Aug 24, 2021

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Previously the custom whitespace removal util could end up removing all whitespace entirely, leaving code like:

<imgsrc="https://nuxtjs.org/logos/nuxt.svg"alt="Nuxt Logo"draggable="false"oncontextmenu="return false;"  />

Reproduction

This change ensures that at least a space remains after this minification.

resolves #9695

Checklist:

  • All new and existing tests are passing.

@danielroe danielroe self-assigned this Aug 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #9705 (0d064bb) into dev (0145578) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9705   +/-   ##
=======================================
  Coverage   65.17%   65.17%           
=======================================
  Files          94       94           
  Lines        4109     4109           
  Branches     1127     1127           
=======================================
  Hits         2678     2678           
  Misses       1152     1152           
  Partials      279      279           
Flag Coverage Δ
unittests 65.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0145578...0d064bb. Read the comment docs.

@danielroe danielroe requested a review from clarkdo August 23, 2021 07:45
@pi0 pi0 merged commit b014777 into dev Aug 24, 2021
@pi0 pi0 deleted the fix/9695-custom-build-indicator branch August 24, 2021 09:10
@pi0 pi0 mentioned this pull request Jun 23, 2022
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CodeSandbox] Custom Loading Indicator breaks SPA build
4 participants